Skip to content

fix: Simplify Torben's previous PR on download URLs #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ralflang wants to merge 1 commit into
base: FRAMEWORK_6_0
Choose a base branch
from
+3 −9
Open

fix: Simplify Torben's previous PR on download URLs #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions js/smartmobile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,19 +974,13 @@ var ImpMobile = {
var list = $('#imp-message-atclist').empty();

$.each(ImpMobile.atc, function(k, v) {
var downloadUrl = v.download_url;
if (typeof downloadUrl !== 'string' || !downloadUrl.length || downloadUrl === '[object Object]') {
// Some backends serialize URL objects in AJAX payloads.
// Fallback: extract href from the rendered download link HTML.
downloadUrl = $('<div></div>').html(v.download || '').find('a').attr('href') || '';
}
if (!downloadUrl.length || downloadUrl === '[object Object]') {
var downloadUrl = String(v.download_url || '');
if (!downloadUrl.length) {
console.log('IMP smartmobile: attachment missing download_url', v);
return;
}
list.append(
$('<li class="imp-message-atc"></li>').append(
// Attachments must bypass jQuery Mobile AJAX navigation so
// binary responses (PDF, etc.) are handled as direct HTTP.
$('<a></a>').attr({
href: downloadUrl,
rel: 'external',
Expand Down