refactor: Explicitly declare the default stack as a prestep to removing fallback logic#7
Merged
Conversation
…ng fallback logic
ralflang
added a commit
to horde/Core
that referenced
this pull request
May 13, 2026
… stack Horde_Injector is a Horde\Injector\Injector and has been for a while. src/ code should type hint Horde\Injector\Injector (compatible with Horde_Injector). Reworked the controller framework - The bootstrap doesn't setup any legacy globals. horde/core now provides a helper to emit a default middleware stack with legacy globals. Routes which need them need to declare HordeCore middleware in their stack. See related PRs for explicitly declaring middleware stacks in multiple apps. horde/skeleton#1 horde/base#88 horde/content#5 horde/jonah#7 horde/trean#4 horde/wicked#23 horde/nag#16 AppRouter is no longer necessary, RuntimeRoutesMapper is used to bootstrap routes from development files. Todo: Implement a PrecompiledRoutesMapper and RoutesMapperCompiler
ralflang
added a commit
to horde/Core
that referenced
this pull request
May 15, 2026
… stack Horde_Injector is a Horde\Injector\Injector and has been for a while. src/ code should type hint Horde\Injector\Injector (compatible with Horde_Injector). Reworked the controller framework - The bootstrap doesn't setup any legacy globals. horde/core now provides a helper to emit a default middleware stack with legacy globals. Routes which need them need to declare HordeCore middleware in their stack. See related PRs for explicitly declaring middleware stacks in multiple apps. horde/skeleton#1 horde/base#88 horde/content#5 horde/jonah#7 horde/trean#4 horde/wicked#23 horde/nag#16 AppRouter is no longer necessary, RuntimeRoutesMapper is used to bootstrap routes from development files. Todo: Implement a PrecompiledRoutesMapper and RoutesMapperCompiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.