Fix body truncation logic in Driver.php#10
Merged
ralflang merged 2 commits intoFRAMEWORK_6_0from Mar 30, 2026
Merged
Conversation
Mnemo: fix ActiveSync HTML note body truncation (toASNote) Summary Corrects the arguments passed to Horde_String::substr() when truncating HTML note bodies for ActiveSync export. The HTML branch mistakenly passed the truncation size as the start offset (second parameter) instead of the length (third parameter), unlike the plain-text branch. Problem For clients that request HTML body preferences with a truncationsize, truncated notes could end up with the wrong slice of text (from offset truncationsize to the end) or an empty body when the note was shorter than the truncation size—especially visible after stricter mb_substr / multibyte handling. That could make notes appear not to sync or show up blank on the device. Change Use Horde_String::substr($memo['body'], 0, $truncationsize) for the HTML truncation path, matching the plain-text path. Files lib/Driver.php — Mnemo_Driver::toASNote()
- Add use statement for Horde\Util\HordeString - Replace FQCN Horde_String:: with imported HordeString:: - Use named parameters in substr() calls for clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mnemo: fix ActiveSync HTML note body truncation (toASNote) Summary
Corrects the arguments passed to Horde_String::substr() when truncating HTML note bodies for ActiveSync export. The HTML branch mistakenly passed the truncation size as the start offset (second parameter) instead of the length (third parameter), unlike the plain-text branch.
Problem
For clients that request HTML body preferences with a truncationsize, truncated notes could end up with the wrong slice of text (from offset truncationsize to the end) or an empty body when the note was shorter than the truncation size—especially visible after stricter mb_substr / multibyte handling. That could make notes appear not to sync or show up blank on the device.
Change
Use Horde_String::substr($memo['body'], 0, $truncationsize) for the HTML truncation path, matching the plain-text path.
Files
lib/Driver.php — Mnemo_Driver::toASNote()