Simplify row existence check in Sql.php#8
Open
TDannhauer wants to merge 1 commit intoFRAMEWORK_6_0from
Open
Conversation
Problem this change fixes: In vendor/horde/mnemo/lib/Driver/Sql.php, getByUID() does: $row = $this->_db->selectOne(...) if (!count($row)) ... On newer PHP/Horde DB behavior, selectOne() can return false when nothing is found. count(false) throws exactly your fatal TypeError. Fix applied: Changed if (!count($row)) to if (!$row) in Mnemo_Driver_Sql::getByUID(). Why this is safe: Preserves existing intent (“no row” => Horde_Exception_NotFound). Avoids PHP 8+ fatal for non-countable values. Doesn’t alter successful row handling. Given your stack (notes_delete via ActiveSync), this crash can interrupt the sync transaction and lead to side effects like seemingly empty data views until the next successful sync/page load. After this patch, that fatal path should be gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem this change fixes:
In vendor/horde/mnemo/lib/Driver/Sql.php, getByUID() does: $row = $this->_db->selectOne(...)
if (!count($row)) ...
On newer PHP/Horde DB behavior, selectOne() can return false when nothing is found. count(false) throws exactly your fatal TypeError.
Fix applied:
Changed if (!count($row)) to if (!$row) in Mnemo_Driver_Sql::getByUID(). Why this is safe:
Preserves existing intent (“no row” => Horde_Exception_NotFound). Avoids PHP 8+ fatal for non-countable values.
Doesn’t alter successful row handling.
Given your stack (notes_delete via ActiveSync), this crash can interrupt the sync transaction and lead to side effects like seemingly empty data views until the next successful sync/page load. After this patch, that fatal path should be gone.