feat: Search Page and topbar search#21
Conversation
Partially adresses #20
TDannhauer
left a comment
TDannhauer
left a comment
There was a problem hiding this comment.
hmm some findings. something to improve?
Empty search: footer removed — Previously, with no query, the page returned pagelist/search + pagelist/footer. The PR returns only pagelist/search. If footer carried navigation or legal text not present in the global layout, that could be a small regression; if the theme already prints a global footer, dropping the duplicate is fine. Worth a quick manual check in the real skin.
Redundant Horde_View on the results path (pre-existing, slightly amplified) — In current Search.php, the first $injector->createInstance('Horde_View') is unused when $searchtext is non-empty; a second Horde_View is created for rendering. The PR sets searchtext on both the first and second instance; the first assignment is still unused for output. Optional cleanup: only create/set the view that actually renders pagelist/search, or reuse one instance end-to-end.
2 participants
Full Text Search
Add search page to sidebar (configurable in conf.xml, new feature)
Restore topbar search in modern PageOutput / Topbar controller helpers. (fix closes #20)