Skip to content

Fix release workflow#29

Closed
fizikiukas wants to merge 8 commits intomainfrom
fix/release
Closed

Fix release workflow#29
fizikiukas wants to merge 8 commits intomainfrom
fix/release

Conversation

@fizikiukas
Copy link
Copy Markdown
Contributor

@fizikiukas fizikiukas commented Dec 4, 2025

Summary by CodeRabbit

  • New Features

    • Added domain-related operations including purchase, availability checking, and nameserver management.
    • Introduced light and dark icon variants for improved visual consistency.
  • Chores

    • Updated to version 1.0.13.
    • Modernized build configuration and tooling.
    • Enhanced CI pipeline with linting and build validation steps.

✏️ Tip: You can customize this high-level summary in your review settings.

@fizikiukas fizikiukas requested a review from a team as a code owner December 4, 2025 07:30
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 4, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR modernizes the project's build tooling and extends the Hostinger API node with domain-related functionality. It removes legacy ESLint configurations, introduces a new ESLint config module, adds build/lint steps to CI/CD, updates npm scripts and dependencies, bumps the version to 1.0.13, and implements domain nameserver management, domain purchase, and availability checking capabilities.

Changes

Cohort / File(s) Summary
Configuration cleanup & migration
\.editorconfig, \.eslintrc.js, \.eslintrc.prepublish.js
Removed legacy ESLint and editor configuration files as part of tooling modernization.
ESLint configuration module
eslint.config.mjs
Added new ESLint configuration module that re-exports config from @n8n/node-cli/eslint.
CI/CD workflow
\.github/workflows/build-release.yaml
Added "Run lint" (npm run lint) and "Build package" (npm run build) steps before the "Publish package" step in the release pipeline.
Project metadata
package.json, README.md, tsconfig.json
Updated version to 1.0.13, added homepage field, refactored npm scripts, upgraded devDependencies (@n8n/node-cli, release-it), enabled strict mode in n8n config, removed main field, and updated version history documentation. tsconfig.json formatting only.
Hostinger credential
credentials/HostingerApi.credentials.ts
Added icon property with light and dark logo paths to the HostingerApi credential type.
Hostinger node implementation
nodes/hostingerApi/HostingerApi.node.ts
Extended domain-related operations including nameserver management (ns1–ns4 fields for domains), domain purchase workflow with contact and coupon inputs, and domain availability checking. Updated icon from string to light/dark object. Added domain-specific request body construction logic with JSON parse error handling.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–25 minutes

  • HostingerApi.node.ts: Review the domain operation branching logic, request body construction for purchaseDomain and checkDomainAvailability, and ensure new domain fields integrate correctly with existing resource/operation filters.
  • package.json: Verify script transitions from old tooling (gulp, eslint-plugin-n8n-nodes-base) to new (@n8n/node-cli), check devDependencies compatibility, and confirm n8n strict mode and nodes array configuration.
  • Workflow changes: Confirm lint and build steps execute before publishing and validate no breaking changes in the new build process.
  • Credential icon paths: Ensure file paths (file:../nodes/hostingerApi/hostingerLogo.svg, .dark.svg) are correctly resolved at runtime.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/release

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbf580e and fc25253.

⛔ Files ignored due to path filters (3)
  • nodes/hostingerApi/hostingerLogo.dark.svg is excluded by !**/*.svg
  • nodes/hostingerApi/hostingerLogo.svg is excluded by !**/*.svg
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (10)
  • .editorconfig (0 hunks)
  • .eslintrc.js (0 hunks)
  • .eslintrc.prepublish.js (0 hunks)
  • .github/workflows/build-release.yaml (1 hunks)
  • README.md (1 hunks)
  • credentials/HostingerApi.credentials.ts (2 hunks)
  • eslint.config.mjs (1 hunks)
  • nodes/hostingerApi/HostingerApi.node.ts (10 hunks)
  • package.json (2 hunks)
  • tsconfig.json (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@fizikiukas fizikiukas closed this Dec 4, 2025
@fizikiukas fizikiukas deleted the fix/release branch December 4, 2025 07:30
dex-botas bot added a commit that referenced this pull request Mar 18, 2026
zygintas pushed a commit that referenced this pull request Mar 18, 2026
Co-authored-by: dex-botas[bot] <194470397+dex-botas[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants