Skip to content

fix: reduce password length requirement#81

Merged
laurynasgadl merged 1 commit intomasterfrom
fix/reduce-password-length-requirement
Sep 15, 2025
Merged

fix: reduce password length requirement#81
laurynasgadl merged 1 commit intomasterfrom
fix/reduce-password-length-requirement

Conversation

@laurynasgadl
Copy link
Copy Markdown
Member

@laurynasgadl laurynasgadl commented Sep 15, 2025

Summary by CodeRabbit

  • Chores
    • Updated default minimum password length from 12 to 6. Users can now set shorter passwords during sign-up and password changes.
    • Streamlined the common-passwords list to a single entry. Only “123456” is blocked as a common password.
    • Users may experience fewer password validation errors. Admins should be aware that password acceptance criteria are less restrictive, potentially affecting security policies and compliance expectations.

@laurynasgadl laurynasgadl merged commit 35afad6 into master Sep 15, 2025
4 of 5 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 15, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The default minimum password length constant was reduced from 12 to 6 in settings. The common-passwords dataset was truncated from 18 entries to 1 entry, leaving only "123456". No other files or logic were changed.

Changes

Cohort / File(s) Summary of Changes
Settings constant update
settings/settings.go
Updated exported constant: DefaultMinimumPasswordLength changed from 12 to 6.
Password blacklist dataset
users/assets/common-passwords.txt
Reduced dataset content: removed multiple common passwords, retaining only 123456. No code changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/reduce-password-length-requirement

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4b9328 and e2e66fd.

📒 Files selected for processing (2)
  • settings/settings.go (1 hunks)
  • users/assets/common-passwords.txt (0 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@laurynasgadl laurynasgadl deleted the fix/reduce-password-length-requirement branch September 15, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant