Add alias for HandlerFactoryInterface #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linaori
reviewed
Dec 15, 2017
Contributor
linaori
left a comment
linaori
left a comment
There was a problem hiding this comment.
Besides of 2 minor things, it looks good to me
|
|
||
| public function action(Request $request, HandlerFactoryInterface $factory) | ||
| { | ||
| $handler = $factory->create(HandlerType\SimpleFormHandler::class); |
Contributor
There was a problem hiding this comment.
Can you add a use statement for this one? Makes it easier to see where it's actually coming from
src/Resources/config/services.yml
Outdated
| Hostnet\Bundle\FormHandlerBundle\Registry\LegacyHandlerRegistry: '@hostnet.form_handler.registry' | ||
| Hostnet\Component\Form\FormProviderInterface: '@form_handler.provider.simple' | ||
| Hostnet\Component\Form\Simple\SimpleFormProvider: '@form_handler.provider.simple' | ||
| Hostnet\Component\FormHandler\HandlerRegistryInterface: '@hostnet.form_handler.registry' |
Contributor
There was a problem hiding this comment.
I think the registry can be safely removed as it shouldn't be used by someone else and we don't use autowiring in the bundle
Contributor
Author
|
Yeah, wasn't sure on the registry one, and felt it needed "on the record" commentary 😉 Both changes made! |
linaori
approved these changes
Dec 15, 2017
yannickl88
approved these changes
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitely a 🐨 derp.
Controller test also now checks a route, hence the require-dev of
symfony/brower-kit