perf: lazy-load UI, chain connectors, and WalletConnect - 97% initial bundle reduction#7
Merged
Merged
Conversation
7d9981e to
496fe9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having a problem with integration kit to the static react project and needed to implement the lazy loadings, chunk retry logic, etc.
refs:
I've been checking some references, and wagmi have dynamic SDK imports in getProvider()), RainbowKit (sideEffects: ["reset.css.ts"], and @solana/wallet-adapter using sideEffects: false + dynamic Ledger SDK import at connect() time.
List of improuvements:
Results (measured with esbuild code-splitting)
Initial entry chunk - 1,154 KB >> 34 KB
UI/Router - in entry >> 1,004 KB deferred chunk (loads on user interaction)
Chain SDKs - in entry >> separate chunks (load on connector init)
WalletConnect - in entry >> deferred (loads on WC init)
Token API calls - immediate on new HotKit() >> on first wallet connect
Tests:
tsc, verified sideEffects paths match the build output, tested wallet connect flow (connectors load on demand), tested bridge/withdraw/deposit UI (router loads on first open), tested token list appears after wallet connects (deferred polling), checked briefly that WalletConnect QR flow still works