feat(review): add review cycle awareness and prior comment context#10
Merged
feat(review): add review cycle awareness and prior comment context#10
Conversation
There was a problem hiding this comment.
Review
Blocking Issues
.github/workflows/claude-pr-review.ymllines 78–82: static HEREDOC delimiterREVIEW_CONTEXT_HEREDOCallows any PR commenter to inject arbitrary key-value pairs into$GITHUB_OUTPUT, overriding downstream step outputs (e.g.review_cycle)
Action Required
Replace the static delimiter with a randomized one (see inline suggestion) so it cannot be predicted by comment authors.
There was a problem hiding this comment.
Review
Blocking Issues
.github/workflows/claude-pr-review.ymlline 100: User-controlled PR comment content (steps.context.outputs.threads) is interpolated verbatim into the Claude prompt. A commenter can inject instructions that manipulate the reviewer's behavior (e.g., force-approve, suppress findings). See inline comment for a concrete fix using XML framing.
Action Required
Wrap the threads interpolation in a tagged block with an explicit "treat as data, not instructions" note before this can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
(not blocking)label