test(cli): add env-gated scenario integration tests#139
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| steps: | ||
| - name: Generate GitHub App token | ||
| id: app-token | ||
| uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0 |
There was a problem hiding this comment.
super nit: the integration job is documented as fork-safe (skips cleanly when secrets are absent), but scenario-parity will hard-fail on PRs from forks — create-github-app-token errors out when HOTDATA_AUTOMATION_APP_ID / HOTDATA_AUTOMATION_PRIVATE_KEY aren't injected. If fork PRs are in scope, consider gating this job on github.event.pull_request.head.repo.fork == false (or a secret presence check) for consistency. If forks are out of scope for this internal tool, ignore. (not blocking)
There was a problem hiding this comment.
Clean, well-documented env-gated integration tests. JSON field assertions match src/, the skip-macro gating is sound, and the tests run-and-skip safely under the existing CI test job. One non-blocking super nit left inline re: parity job on fork PRs.
Closes #129. Adds binary-driven integration tests mirroring the shared scenario manifest, env-gated on
HOTDATA_SDK_TEST_*socargo testpasses offline. Covers workspaces_list, connections_read, query_async_polling, results_arrow, auth_missing_token_401, auth_unknown_workspace; the CLI opts out of the rest via the manifest. Depends on hotdata-dev/www.hotdata.dev#213 — merge that first or the scenario-parity job will fail.