ci: post #deploy Slack message on CLI release#194
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Clean, well-guarded change. Verified the Slack step only runs on real tag releases (host requires publishing == true, announce requires host success), continue-on-error keeps a published release from being marked failed, the JSON is built safely with jq --arg, the message backticks are escaped, the token is never echoed, and .ok is asserted to catch Slack's HTTP-200-on-error responses. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Slack notification to the release workflow's
announcejob so CLI releases post the same clean📦 hotdata-cli vX.Y.Z released — release notesmessage in #deploy that the SDKs use, instead of relying on the generic GitHub-app workflow notification. Reuses the sharedSLACK_CI_BOT_TOKENorg secret (now scoped to this repo) and the #deploy channel.