Skip to content

chore: Release hotdata-cli version 0.1.14#64

Merged
eddietejeda merged 4 commits intomainfrom
release/0.1.14
Apr 28, 2026
Merged

chore: Release hotdata-cli version 0.1.14#64
eddietejeda merged 4 commits intomainfrom
release/0.1.14

Conversation

@eddietejeda
Copy link
Copy Markdown
Contributor

Bump version and regenerate changelog for indexes workspace list and test coverage. Apply clippy fixes, resolve items-after-test-module in auth and sandbox, and run rustfmt for a clean fmt check.

Bump version and regenerate changelog for indexes workspace list and
test coverage. Apply clippy fixes, resolve items-after-test-module in
auth and sandbox, and run rustfmt for a clean fmt check.
@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 27, 2026

claude[bot]
claude Bot previously approved these changes Apr 27, 2026
Resolve conflicts by adopting JWT session flow and API client from main.
Apply clippy-friendly follow-ups: format_fail_message in api, split_once
and print_row before tests in auth, Default derives in config, jwt
ensure_access_token branch, util api_error before tests module.
claude[bot]
claude Bot previously approved these changes Apr 27, 2026
Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting, clippy fixes, version bump, and new tests all look clean. A couple of nits on the workspace-wide list path.

Patch targets only lines changed in a PR; release and formatting diffs
often lower that percentage without indicating a regression. Keep
upload and project trends; stop patch status from failing checks.
Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: super nit at src/api.rs — double blank line between test_new and fail_response (lines 72–76). Rustfmt normally enforces a single blank line between items; this one slipped through. (not blocking)

claude[bot]
claude Bot previously approved these changes Apr 27, 2026
Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: collect_tables in src/indexes.rs has a test for a single-page response but no test for multi-page pagination. The information_schema_followup helper is tested in isolation (good), but the cursor carry-over loop itself — where a first response returns has_more: true and next_cursor: "page2", and a second mock asserts cursor=page2 — is not verified end-to-end. Worth adding a collect_tables_two_pages test so the wiring is pinned. (not blocking)

git-cliff updated the release section (date, codecov chore). The main
auth commit used a non-conventional subject (missing colon), so cliff
skipped it; document JWT session support explicitly.
@eddietejeda eddietejeda merged commit c318258 into main Apr 28, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant