feat(databases): add --expires-at option to databases create#97
Merged
Conversation
Contributor
There was a problem hiding this comment.
Review
Blocking Issues
src/databases.rs:129—create_database_requestgained a required 4th parameterexpires_at: Option<&str>, but the six existing test callers in the same file (lines 655, 661, 668, 681, 863, 873) were not updated.cargo test/cargo check --testswill fail to compile.
Action Required
- Update all six test invocations of
create_database_requestto pass the newexpires_atargument (likelyNone). - Add test coverage for the new flag: at minimum, assert that
Some("24h")is serialized into the request body asexpires_at, and that the field is absent whenNone.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--expires-atflag tohotdata databases create24h,7d,90m) or an RFC 3339 timestamp24hFollows hotdata-dev/runtimedb#471 which added
expires_atsupport to the API.🤖 Generated with Claude Code