Skip to content

feat(databases): add --expires-at option to databases create#97

Merged
eddietejeda merged 3 commits into
mainfrom
feat/databases-expires-at
May 23, 2026
Merged

feat(databases): add --expires-at option to databases create#97
eddietejeda merged 3 commits into
mainfrom
feat/databases-expires-at

Conversation

@eddietejeda
Copy link
Copy Markdown
Contributor

Summary

  • Adds --expires-at flag to hotdata databases create
  • Accepts a relative duration (e.g. 24h, 7d, 90m) or an RFC 3339 timestamp
  • Omitting the flag lets the API default to 24h

Follows hotdata-dev/runtimedb#471 which added expires_at support to the API.

🤖 Generated with Claude Code

Comment thread src/databases.rs
Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Blocking Issues

  • src/databases.rs:129create_database_request gained a required 4th parameter expires_at: Option<&str>, but the six existing test callers in the same file (lines 655, 661, 668, 681, 863, 873) were not updated. cargo test / cargo check --tests will fail to compile.

Action Required

  • Update all six test invocations of create_database_request to pass the new expires_at argument (likely None).
  • Add test coverage for the new flag: at minimum, assert that Some("24h") is serialized into the request body as expires_at, and that the field is absent when None.

Comment thread src/databases.rs
claude[bot]
claude Bot previously approved these changes May 23, 2026
@sentry
Copy link
Copy Markdown

sentry Bot commented May 23, 2026

Codecov Report

❌ Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/databases.rs 91.30% 2 Missing ⚠️
src/main.rs 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@eddietejeda eddietejeda merged commit bef1d29 into main May 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant