feat: add database parameter to execute_sql for managed database scoping#11
Merged
Merged
Conversation
Adds an optional keyword-only `database` parameter to `execute_sql`. When provided, the database name is resolved to an ID once before the retry loop and passed as the `X-Database-Id` header on every query attempt. Inside a managed database the built-in catalog is always "default", so callers should reference tables as "default"."<schema>"."<table>". Without the parameter, behaviour is unchanged (no header sent). All downstream integration libraries (hotdata-langchain, hotdata-llamaindex, hotdata-langgraph, hotdata-jupyter, hotdata-marimo, hotdata-streamlit) were calling execute_sql without database scoping, causing 400 errors when querying managed database tables. They can now pass database="<name>" to fix the issue without any further changes.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
databasekeyword argument toexecute_sqlso callers can scope queries to a managed database without dropping down to theQueryApidirectly.When
databaseis provided, the name is resolved to a database ID once before the retry loop and sent as theX-Database-Idheader on every attempt. When omitted, behaviour is identical to before (no header, fully backwards-compatible).Inside a managed database the built-in catalog is always
default, so callers should reference tables as"default"."schema"."table".Why
Six downstream integration libraries (hotdata-langchain, hotdata-llamaindex, hotdata-langgraph, hotdata-jupyter, hotdata-marimo, hotdata-streamlit) all call
execute_sqlwithout database scoping. Any SQL referencing a managed database table returns a 400 today. Each library can fix the issue by addingdatabase=...at their call sites with no other changes needed.Changes
execute_sql(sql, *, database=None)resolves the name to an ID when provided_execute_sql_once(sql, *, database_id=None)passesx_database_idtoQueryApi.querywhen set