Skip to content

feat: add managed database helpers to HotdataClient#4

Merged
eddietejeda merged 4 commits into
mainfrom
feat/managed-databases
May 19, 2026
Merged

feat: add managed database helpers to HotdataClient#4
eddietejeda merged 4 commits into
mainfrom
feat/managed-databases

Conversation

@eddietejeda
Copy link
Copy Markdown
Contributor

@eddietejeda eddietejeda commented May 19, 2026

Summary

  • Add hotdata_runtime/databases.py with managed database dataclasses and request builders
  • Extend HotdataClient with create/list/load/delete managed database operations, parquet upload, and table load helpers
  • Mirror the hotdata databases CLI workflow (source_type: managed, declare tables at create time, parquet-only loads)
  • Bump to 0.1.1 and require hotdata>=0.2.0
  • Update runtime contract, README, and tests

Test plan

  • uv run pytest (47 passed)

Release

After merge, tag v0.1.1 to publish to PyPI (hotdata 0.2.0 is already published).

Expose create/list/load/delete managed database operations through the
runtime contract, mirroring hotdata-cli and the latest SDK managed-table APIs.
Comment thread pyproject.toml Outdated
Comment thread hotdata_runtime/client.py Outdated
Comment thread hotdata_runtime/databases.py Outdated
Comment thread hotdata_runtime/databases.py
Comment thread tests/test_databases.py Outdated
Comment thread hotdata_runtime/client.py Outdated
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Blocking Issues

  • pyproject.toml:16 — the hotdata dependency now points at an unpinned git URL (git+https://github.com/hotdata-dev/sdk-python.git). Without a tag/branch/commit pin, every install pulls the SDK's current default branch, so reproducibility is broken for anyone consuming this package outside the local uv-sources override.

Action Required

  • Pin the git dependency to a specific tag or commit SHA, or publish a new hotdata SDK release with the managed-table API and bump the PyPI lower bound.

Use PyPI version constraints instead of git URLs. Managed database APIs
require hotdata 0.1.1; keep a sibling sdk-python path override for local
development until that release is published.
claude[bot]
claude Bot previously approved these changes May 19, 2026
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior blocking concern (unpinned git URL) resolved by pinning to hotdata>=0.1.1 with a local-only uv source override for development. No new blocking issues.

claude[bot]
claude Bot previously approved these changes May 19, 2026
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior blocking concern (unpinned git URL) resolved — hotdata>=0.2.0 is now a proper PyPI version constraint, with the sibling-checkout override scoped to local dev via [tool.uv.sources]. No new blocking issues.

Rename cross-module helpers, remove unused imports, simplify parquet detection, and clarify upload_id/file handling in load_managed_table.
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All prior feedback addressed (blocking dependency pin + nits). No new issues.

@eddietejeda eddietejeda merged commit 82a05bb into main May 19, 2026
1 check passed
@eddietejeda eddietejeda mentioned this pull request May 19, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant