Skip to content

ci(publish): post to #deploy on PyPI publish#115

Merged
zfarrell merged 2 commits into
mainfrom
ci/slack-publish-notify
Jun 16, 2026
Merged

ci(publish): post to #deploy on PyPI publish#115
zfarrell merged 2 commits into
mainfrom
ci/slack-publish-notify

Conversation

@zfarrell

Copy link
Copy Markdown
Contributor

Mirrors the sdk-rust change: posts a release announcement to #deploy after a successful PyPI publish, via the shared Hotdata CI Slack app (SLACK_CI_BOT_TOKEN org secret). Skips gracefully if the secret is unset, and continue-on-error keeps a Slack hiccup from reddening an already-successful publish.

Comment thread .github/workflows/publish.yml Outdated
claude[bot]
claude Bot previously approved these changes Jun 16, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean change. JSON is safely constructed, the .ok assertion correctly handles Slack's always-200 API, and continue-on-error appropriately protects the irreversible publish. One non-blocking observability suggestion inline.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-documented workflow change. The .ok error-surfacing suggestion from the prior thread is already implemented. No issues.

@zfarrell zfarrell merged commit 9cb237c into main Jun 16, 2026
4 checks passed
@zfarrell zfarrell deleted the ci/slack-publish-notify branch June 16, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant