fix: type x_database_id on execute_saved_query (regenerate client)#94
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
||
| - Typed `x_database_id` parameter on `SavedQueriesApi.execute_saved_query` (required) and `DatasetsApi.create_dataset`, scoping execution to a database the same way `QueryApi.query` does — no more `_headers` override. | ||
| - `database_id` field on `QueryRequest` as a body-level alternative to the `X-Database-Id` header. | ||
| - `storage_backend` field on `CreateDatabaseRequest` to select the default catalog's physical backend (`parquet` or `ducklake`). |
There was a problem hiding this comment.
nit: (not blocking) The regenerated CreateDatabaseRequest.expires_at description changed from "Defaults to 24h when omitted" to "Omitted (or empty) means the database never expires" — a meaningful behavior change that callers relying on implicit 24h auto-expiry would want to know about. Worth a ### Changed entry here so it doesn't get lost in the regeneration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates the client from the current OpenAPI spec, which now declares the required
X-Database-Idheader onexecute_saved_query— so it's a typedx_database_idparam likequery(). Replaces the_headersworkaround in the saved-query versioning integration test. Closes #93.