Improved: support to upload csv file when updating inventory(#279) #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: support to parse json to csv before upload Added check for error message in api and display a toast message in both inventory and po upload case
Merged
1 task
R-Sourabh
added a commit
to R-Sourabh/import
that referenced
this pull request
Apr 16, 2024
R-Sourabh
pushed a commit
to R-Sourabh/import
that referenced
this pull request
Apr 16, 2024
R-Sourabh
added a commit
to R-Sourabh/import
that referenced
this pull request
Apr 16, 2024
R-Sourabh
pushed a commit
to R-Sourabh/import
that referenced
this pull request
Apr 16, 2024
Implemented: support to use i18n from dxp and removed app level configuration of i18n(dxp/280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: support to parse json to csv before upload
Added check for error message in api and display a toast message in both inventory and po upload case
Related Issues
Related Issue #279
Short Description and Why It's Useful
Changed the file from json to csv format before uploading as multi-threading does not support processing of json files.
Does not made this change for PurchaseOrder upload case as for now we do not enable multithreading support for po's as discussed.
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance