Prevent pull to refresh on specific elements #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonvogt
commented
Feb 16, 2025
… trigger pull to refresh mechanism
…ventsPullsToRefresh` for clarity
leonvogt
force-pushed
the
add-prevent-pull-to-refresh
branch
from
aed61f8 to
7c2afbf
Compare
Contributor
|
Fyi @leonvogt I've added site reference documentation here: hotwired/hotwire-native-site#74 |
Contributor
Author
|
Awesome, thank you @jayohms! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to prevent the pull to refresh behavior on specific elements.
When an element (or its ancestor) hasdata-hotwire-native-prevent-pull-to-refreshattribute, pull to refresh is disabled.When an element (or its ancestor) has
data-native-prevent-pull-to-refreshattribute, pull to refresh is disabled.All the examples shown in #97 could be solved by adding the data attribute to the respective elements.
This introduces a difference from Hotwire Native iOS, since iOS doesn't need this attribute, which isn't ideal.
But I currently don't see a better solution. Happy to discuss this further and maybe find a better solution.