feat: Add type coverage support using mypy#62
Conversation
houfu
left a comment
There was a problem hiding this comment.
Looks good overall! Left a few minor suggestions but nothing blocking. Feel free to merge as-is or address them—up to you.
|
Great work on this PR! 🎉 I noticed that GitHub will automatically close both issues #54 and #56 when this PR is merged, even though the PR description says "partially resolves #54". GitHub's parser detected the keyword "resolves" next to #54 and is treating it as an auto-close trigger, ignoring the "partially" qualifier. Since #54 is only partially completed (with docs changes and version bump still pending), you might want to update the PR description to prevent it from auto-closing: Current: Suggested: This way only #56 will close automatically, and #54 will remain open for the remaining work (version bump, docs, pre-commit setup, etc.). |
|
thx :) updated the pr desc and made the minor changes, rest of the release work can be carried over as part of #54 |
Completely resolves #56 and partially addresses #54
#56
py.typedmarker file to packagelist[str]instead ofList[str])#54
match/casein redlines.py)sysin cli.py regarding python version requiredPending or Not Done
cc: @houfu