Skip to content

Fix CI for expanded output format support#10

Merged
houjun merged 6 commits into
mainfrom
pr-9-ci-fix
Apr 21, 2026
Merged

Fix CI for expanded output format support#10
houjun merged 6 commits into
mainfrom
pr-9-ci-fix

Conversation

@houjun
Copy link
Copy Markdown
Owner

@houjun houjun commented Apr 21, 2026

This replaces #9, which could not be updated directly because the original source branch is not accessible.

Changes included:

  • fix ESSI output creation for HDF5 and CSV inputs
  • preserve CSV coordinate precision to avoid boundary-domain failures
  • write CSV->ESSI output to an HDF5 filename instead of the CSV source name
  • update tests and README to match the expanded output-format behavior

Validation:

  • python -m unittest discover -s tests -p "test_*.py"
  • single-process conversion check matching the CI fixture validation

Supersedes #9.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands output-format support so that HDF5 (.h5) and CSV inputs can generate ESSI and OpenSees-style outputs (in addition to the existing “point” output), and updates tests/docs to match.

Changes:

  • Allow explicit --output-format overrides for all input kinds (DRM/HDF5/CSV/template).
  • Fix ESSI output filename selection for CSV inputs (write to .h5 output rather than the source .csv name).
  • Update unit tests and README to validate/document the expanded behavior.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
convert.py Broadens supported output modes, adjusts ESSI output naming for CSV, and updates ESSI HDF5 creation logic.
tests/test_convert_helpers.py Updates expectations for output-mode resolution and output filename behavior.
tests/test_convert_fixture_data.py Adds fixture-driven tests for HDF5→ESSI/OpenSees and CSV→ESSI conversions.
template/motion_setting.csv Normalizes CSV fixture formatting (line ending / newline consistency).
README.md Documents that all output formats are supported across input kinds and clarifies metadata behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread convert.py Outdated
Comment thread convert.py Outdated
Comment thread convert.py Outdated
Comment thread convert.py Outdated
Comment thread convert.py Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@houjun houjun merged commit cf1fe18 into main Apr 21, 2026
5 checks passed
@houjun houjun deleted the pr-9-ci-fix branch April 21, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants