Closed
Conversation
... and is part of a list of binaries which also end in xz
i.e.:
https://github.com/mfontani/tstdin/releases/tag/v0.2.3
... which ubi ought to be able to cope about, but can't.
I had to resort to making a release with ".gz" files, i.e.:
https://github.com/mfontani/tstdin/releases/tag/v0.2.4
... which is exactly the same, but uses gzip instead of xzip.
Next patch will fix that.
... treating them the same as if they are .gz, basically.
This fixes the problem I was having with:
https://github.com/mfontani/tstdin/releases/tag/v0.2.3
... which has been added as a test case to the test suite.
mfontani
force-pushed
the
fix_binary_ending_in_xz
branch
from
6f50ff2 to
fd7e96e
Compare
Member
|
Hi, thanks for your PR! I'm pretty finicky about my projects (see this blog post for details), so I rarely merge a PR as-is. I can move forward on your PR in one of two ways:
Please let me know which approach you'd prefer. If I don't hear from you before I get around to working on this PR I'll go with option #1. Thanks again for your contribution! (But I recently tried option #2 with someone on another project and I couldn't push to their PR branch even though they'd checked the box to do so, so I can't promise it will work.) |
Contributor
Author
|
Option 1 is fine, thanks! |
Member
|
Merged from the CLI. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I previously submitted a patch for making
.xzDWIM, but it wasn't enough.On another project, I added a list of multi-arch binaries which are then xz'ed, but ubi didn't work:
$ cargo run -- --project mfontani/tstdin --tag v0.2.3 Finished dev [unoptimized + debuginfo] target(s) in 0.11s Running `target/debug/ubi --project mfontani/tstdin --tag v0.2.3` [ubi][ERROR] could not find a release for this OS and architecture from tstdin-darwin-amd64.xz, tstdin-linux-amd64.xz, tstdin.exeThe os (linux) matches; the arch (amd64) matches; it "just" chokes on the ".xz" ending, which it can totally handle.
So I'm adding ".xz" to the list of extensions it does, indeed, support.
... and the actual problem is now a test case, too.