Skip to content
This repository was archived by the owner on Nov 22, 2022. It is now read-only.

chore(package.json): update package.json #24

Merged
elfrank merged 2 commits into from
Oct 1, 2019
Merged

chore(package.json): update package.json #24

elfrank merged 2 commits into from
Oct 1, 2019

Conversation

@elfrank
Copy link
Collaborator

@elfrank elfrank commented Oct 1, 2019 •
edited
Loading

Brief Description

update the package.json file in preparation to publish the project as
a module in the npm registry.

Pull Request Guidelines

  • I have added pull requests labels which describe my contribution.
  • All existing tests passed.
    • I have added tests to cover my changes, of which pass.
  • I have compared the render output of my branch to master.
  • My code has passed the ESLint configuration for this project.
  • My change requires modifications to the documentation.
    • I have updated the documentation accordingly.

@elfrank
chore(package.json): update package.json
fb4077a 
update the `package.json` file in preparation to publish the project as
a module in the npm registry. The package will be under the `@hover`
scope, such as https://www.npmjs.com/package/@hover/javascript
@elfrank elfrank self-assigned this Oct 1, 2019
@elfrank elfrank added the refactor Restructured code without change to behavior label Oct 1, 2019
jaxry
jaxry approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@jaxry jaxry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@elfrank elfrank merged commit 923c9a1 into master Oct 1, 2019
@elfrank elfrank deleted the chore-npm-publish-ready branch October 2, 2019 23:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carlos-lopez-garces carlos-lopez-garces Awaiting requested review from carlos-lopez-garces

@lyonsno lyonsno Awaiting requested review from lyonsno

@santiagoroca santiagoroca Awaiting requested review from santiagoroca

1 more reviewer

@jaxry jaxry jaxry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@elfrank elfrank

Labels

refactor Restructured code without change to behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elfrank @jaxry