Skip to content

feat!(action/docker/build-image): use gha cache backend#335

Merged
neilime merged 1 commit intomainfrom
152-featdockerbuild-image-use-gha-cache-backend
Oct 11, 2024
Merged

feat!(action/docker/build-image): use gha cache backend#335
neilime merged 1 commit intomainfrom
152-featdockerbuild-image-use-gha-cache-backend

Conversation

@neilime
Copy link
Copy Markdown
Member

@neilime neilime commented Sep 25, 2024

No description provided.

@neilime neilime linked an issue Sep 25, 2024 that may be closed by this pull request
@neilime neilime self-assigned this Sep 25, 2024
@neilime neilime added the enhancement New feature or request label Sep 25, 2024
@neilime neilime force-pushed the 152-featdockerbuild-image-use-gha-cache-backend branch from f6ab55a to 6a5233b Compare October 9, 2024 09:39
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
@neilime neilime force-pushed the 152-featdockerbuild-image-use-gha-cache-backend branch from 6a5233b to a2eb654 Compare October 11, 2024 08:56
@neilime neilime changed the title feat(action/docker/build-image): use gha cache backend feat!(action/docker/build-image): use gha cache backend Oct 11, 2024
@neilime neilime merged commit 0b90695 into main Oct 11, 2024
@neilime neilime deleted the 152-featdockerbuild-image-use-gha-cache-backend branch October 11, 2024 09:04
@NikitaCOEUR
Copy link
Copy Markdown
Contributor

@neilime
It is marked in the definition of release 0.21.0 :

Since 0.19.0, docker-build-images is using gha backend cache, so no more cache image (ghcr.io/my-org/my-repo/my-image/cache) are created in the registry. It is reasonable to delete the existing one are they are useless.

But here, there's still the definition of the image to be cached with the /cache mention, is that normal?
https://github.com/hoverkraft-tech/ci-github-container/pull/335/files#diff-b1a31054574d361286a45d0269d77a0c0845e02d0ff84821308827c5e370a869L142

Does the cache still work? We're having trouble explaining the behavior of layers that are replayed between two pushes on the same PR and that logically shouldn't be played...

@neilime
Copy link
Copy Markdown
Member Author

neilime commented Feb 28, 2025

@NikitaCOEUR, you're right. There was a extra "/cache" in the image name, not sure it was a problem as the cache backend was using this for fetching and pulling cache, but we have fixed it to avoid confusion.

As some people asked for it, we have added an option to choose the cache backend type: https://github.com/hoverkraft-tech/ci-github-container/releases/tag/0.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(docker/build-image): use GHA cache backend

2 participants