Skip to content

fix: kind cluster must access private registries#338

Merged
neilime merged 1 commit intomainfrom
fix/kind-cluster-private-registries
Oct 11, 2024
Merged

fix: kind cluster must access private registries#338
neilime merged 1 commit intomainfrom
fix/kind-cluster-private-registries

Conversation

@fredleger
Copy link
Copy Markdown
Contributor

No description provided.

@fredleger fredleger self-assigned this Sep 25, 2024
@fredleger fredleger added the bug Something isn't working label Sep 25, 2024
@fredleger
Copy link
Copy Markdown
Contributor Author

May fix #321

@fredleger fredleger force-pushed the fix/kind-cluster-private-registries branch 4 times, most recently from e037c76 to 09b9b3c Compare September 25, 2024 15:59
@fredleger fredleger requested a review from neilime September 25, 2024 16:56
@fredleger
Copy link
Copy Markdown
Contributor Author

This is passing tests but...

  1. the test chart is not modified so we should either generate some tests changes or force the helm install anyway
  2. be sure our test case is using a private image

Comment thread actions/helm/test-chart/action.yml Outdated
@fredleger fredleger force-pushed the fix/kind-cluster-private-registries branch 3 times, most recently from 5a8be63 to b0930f0 Compare September 27, 2024 14:00
@fredleger
Copy link
Copy Markdown
Contributor Author

up @neilime ?

Update actions/helm/test-chart/action.yml

Co-authored-by: Emilien Escalle <neilime@users.noreply.github.com>
Signed-off-by: Frederic Leger <fredleger@users.noreply.github.com>
@neilime neilime force-pushed the fix/kind-cluster-private-registries branch from b0930f0 to bc6048b Compare October 11, 2024 08:46
Copy link
Copy Markdown
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilime neilime merged commit bf86a9c into main Oct 11, 2024
@neilime neilime deleted the fix/kind-cluster-private-registries branch October 11, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] kind cluster must be able to access OCI private registry such as ghcr.io

2 participants