fix: reorder markdown processing to run prettier after markdownlint #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Fix helm-docs job lint issues after README generation
fix: disable MD060 rule in helm-docs default markdownlint config
Dec 2, 2025
Contributor
Author
Reverted the MD060 disable and instead reordered the steps so prettier runs after markdownlint fix. The new order is: textlint → markdownlint fix → prettier → validate. This ensures prettier's table formatting (with aligned columns) is the final result before validation. (d172a36) |
Copilot
AI
changed the title
fix: disable MD060 rule in helm-docs default markdownlint config
fix: reorder markdown processing to run prettier after markdownlint
Dec 2, 2025
MD060 (table-column-style) conflicts with Prettier's table formatting and cannot be auto-fixed. This rule requires aligned table pipes, but Prettier removes alignment padding when formatting markdown. Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
Changed the order of steps in generate-docs action: - Old order: textlint → prettier → markdownlint --fix → validate - New order: textlint → markdownlint --fix → prettier → validate This ensures prettier's table formatting (with aligned columns) is the final result before validation, avoiding MD060 lint errors. Also added ignoreReturnCode: true to markdownlint fix step so it doesn't fail on unfixable issues before prettier can format. Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
neilime
force-pushed
the
copilot/fix-helm-docs-lint-issues
branch
from
d172a36 to
22d2fb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helm-docs job fails because markdownlint's MD060 rule (table-column-style) reports errors after Prettier formats the markdown tables. The issue was the step ordering: Prettier was running before markdownlint, but it should run after so that Prettier's table formatting (with aligned columns) is the final result.
Changes
actions/helm/generate-docs/action.yml:ignoreReturnCode: trueto the markdownlint fix step so it doesn't fail on unfixable issues before prettier can formatfix: truefrom the final validation step since formatting is now completeThis ensures Prettier's table formatting (with properly aligned columns) is the final result before validation, avoiding MD060 lint errors while keeping the rule enabled for proper file formatting.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.