Skip to content

feat(docker): support structured OCI registry inputs for separate pull, push, and cache targets#685

Merged
neilime merged 7 commits intomainfrom
copilot/add-multiple-registry-support
Mar 12, 2026
Merged

feat(docker): support structured OCI registry inputs for separate pull, push, and cache targets#685
neilime merged 7 commits intomainfrom
copilot/add-multiple-registry-support

Conversation

Copy link
Contributor

Copilot AI commented Mar 10, 2026

  • Inspect the new review feedback on actions/docker/build-image
  • Review the affected script block and current cache registry handling
  • Move expression-based script inputs to environment variables
  • Assert the cache registry is defined before generating registry cache configuration
  • Run targeted validation for the touched files
  • Run final review/security checks and reply to the new PR comments

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Add support for multiple registries for pull, push, and cache Support structured OCI registry inputs for separate pull, push, and cache targets Mar 10, 2026
Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
@neilime neilime marked this pull request as ready for review March 11, 2026 13:56
@neilime neilime force-pushed the copilot/add-multiple-registry-support branch from 1e19130 to 7db723f Compare March 11, 2026 13:56
@neilime neilime changed the title Support structured OCI registry inputs for separate pull, push, and cache targets feat(docker): support structured OCI registry inputs for separate pull, push, and cache targets Mar 11, 2026
Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot handle feedbacks

Copilot AI and others added 2 commits March 11, 2026 14:19
Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 11, 2026

@copilot handle feedbacks

Addressed the review feedback in d394437.

Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot, dont mark original format for oci-registry-username, oci-registry-password and oci-registry as "legacy", this is the default mode, still relevant

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 11, 2026

@copilot, dont mark original format for oci-registry-username, oci-registry-password and oci-registry as "legacy", this is the default mode, still relevant

Updated the wording so the scalar input form is described as the default format, and renamed the internal legacy markers to scalar, in 81b7db4.

Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot handle feedbacks

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 12, 2026

@copilot handle feedbacks

Handled in 6a40375.

Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot handle feedbacks

Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 12, 2026

@copilot handle feedbacks

Handled in f00ebb6.

Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot handle feedbacks

Copy link
Contributor Author

Copilot AI commented Mar 12, 2026

@copilot handle feedbacks

Handled in 7b3ce1c.

@neilime neilime force-pushed the copilot/add-multiple-registry-support branch 4 times, most recently from 0e866f9 to 4886483 Compare March 12, 2026 09:58
Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
@neilime neilime force-pushed the copilot/add-multiple-registry-support branch from 4886483 to 33885df Compare March 12, 2026 10:12
@neilime neilime merged commit 86740f4 into main Mar 12, 2026
91 checks passed
@neilime neilime deleted the copilot/add-multiple-registry-support branch March 12, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants