Skip to content

Commit 294c815

Browse files
committed
Updated Yardoc for CAtomicBoolean and CAtomicFixnum.
1 parent 825ef93 commit 294c815

File tree

3 files changed

+69
-30
lines changed

3 files changed

+69
-30
lines changed

.yardopts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
--template-path ./yard-template
99

1010
./lib/**/*.rb
11+
./ext/concurrent_ruby_ext/**/*.c
1112
-
1213
README.md
1314
LICENSE.txt

lib/concurrent/atomic/atomic_boolean.rb

Lines changed: 37 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,20 @@ module Concurrent
66
# boolean and thread-safe and guaranteed to succeed. Reads and writes may block
77
# briefly but no explicit locking is required.
88
#
9-
# @since 0.6.0
109
# @see http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/atomic/AtomicBoolean.html java.util.concurrent.atomic.AtomicBoolean
1110
class MutexAtomicBoolean
1211

1312
# @!macro [attach] atomic_boolean_method_initialize
1413
#
15-
# Creates a new `AtomicBoolean` with the given initial value.
14+
# Creates a new `AtomicBoolean` with the given initial value.
1615
#
17-
# @param [Boolean] initial the initial value
16+
# @param [Boolean] initial the initial value
1817
def initialize(initial = false)
1918
@value = !!initial
2019
@mutex = Mutex.new
2120
end
2221

23-
# @!macro [attach] atomic_boolean_method_value
22+
# @!macro [attach] atomic_boolean_method_value_get
2423
#
2524
# Retrieves the current `Boolean` value.
2625
#
@@ -32,7 +31,7 @@ def value
3231
@mutex.unlock
3332
end
3433

35-
# @!macro [attach] atomic_boolean_method_value_eq
34+
# @!macro [attach] atomic_boolean_method_value_set
3635
#
3736
# Explicitly sets the value.
3837
#
@@ -47,9 +46,9 @@ def value=(value)
4746
@mutex.unlock
4847
end
4948

50-
# @!macro [attach] atomic_boolean_method_is_true
49+
# @!macro [attach] atomic_boolean_method_true_question
5150
#
52-
# Is the current value `true`?
51+
# Is the current value `true`
5352
#
5453
# @return [Boolean] true if the current value is `true`, else false
5554
def true?
@@ -59,9 +58,9 @@ def true?
5958
@mutex.unlock
6059
end
6160

62-
# @!macro [attach] atomic_boolean_method_is_false
61+
# @!macro atomic_boolean_method_false_question
6362
#
64-
# Is the current value `true`?false
63+
# Is the current value `false`
6564
#
6665
# @return [Boolean] true if the current value is `false`, else false
6766
def false?
@@ -111,24 +110,24 @@ def initialize(initial = false)
111110
@atomic = java.util.concurrent.atomic.AtomicBoolean.new(!!initial)
112111
end
113112

114-
# @!macro atomic_boolean_method_value
113+
# @!macro atomic_boolean_method_value_get
115114
#
116115
def value
117116
@atomic.get
118117
end
119118

120-
# @!macro atomic_boolean_method_value_eq
119+
# @!macro atomic_boolean_method_value_set
121120
#
122121
def value=(value)
123122
@atomic.set(!!value)
124123
end
125124

126-
# @!macro [attach] atomic_boolean_method_is_true
125+
# @!macro atomic_boolean_method_true_question
127126
def true?
128127
@atomic.get
129128
end
130129

131-
# @!macro [attach] atomic_boolean_method_is_false
130+
# @!macro atomic_boolean_method_false_question
132131
def false?
133132
!@atomic.get
134133
end
@@ -144,13 +143,37 @@ def make_false
144143
end
145144
end
146145

147-
148146
# @!macro atomic_boolean
149147
class AtomicBoolean < JavaAtomicBoolean
150148
end
151149

152150
elsif defined? Concurrent::CAtomicBoolean
153151

152+
# @!macro atomic_boolean
153+
class CAtomicBoolean
154+
155+
# @!method initialize
156+
# @!macro atomic_boolean_method_initialize
157+
158+
# @!method value
159+
# @!macro atomic_boolean_method_value_get
160+
161+
# @!method value=
162+
# @!macro atomic_boolean_method_value_set
163+
164+
# @!method true?
165+
# @!macro atomic_boolean_method_true_question
166+
167+
# @!method false?
168+
# @!macro atomic_boolean_method_false_question
169+
170+
# @!method make_true
171+
# @!macro atomic_boolean_method_make_true
172+
173+
# @!method make_false
174+
# @!macro atomic_boolean_method_make_false
175+
end
176+
154177
# @!macro atomic_boolean
155178
class AtomicBoolean < CAtomicBoolean
156179
end

lib/concurrent/atomic/atomic_fixnum.rb

Lines changed: 31 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ module Concurrent
66
# fixnum and thread-safe and guaranteed to succeed. Reads and writes may block
77
# briefly but no explicit locking is required.
88
#
9-
# @since 0.5.0
109
# @see http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/atomic/AtomicLong.html java.util.concurrent.atomic.AtomicLong
1110
class MutexAtomicFixnum
1211

@@ -16,17 +15,17 @@ class MutexAtomicFixnum
1615

1716
# @!macro [attach] atomic_fixnum_method_initialize
1817
#
19-
# Creates a new `AtomicFixnum` with the given initial value.
18+
# Creates a new `AtomicFixnum` with the given initial value.
2019
#
21-
# @param [Fixnum] init the initial value
22-
# @raise [ArgumentError] if the initial value is not a `Fixnum`
20+
# @param [Fixnum] init the initial value
21+
# @raise [ArgumentError] if the initial value is not a `Fixnum`
2322
def initialize(init = 0)
2423
raise ArgumentError.new('initial value must be a Fixnum') unless init.is_a?(Fixnum)
2524
@value = init
2625
@mutex = Mutex.new
2726
end
2827

29-
# @!macro [attach] atomic_fixnum_method_value
28+
# @!macro [attach] atomic_fixnum_method_value_get
3029
#
3130
# Retrieves the current `Fixnum` value.
3231
#
@@ -38,7 +37,7 @@ def value
3837
@mutex.unlock
3938
end
4039

41-
# @!macro [attach] atomic_fixnum_method_value_eq
40+
# @!macro [attach] atomic_fixnum_method_value_set
4241
#
4342
# Explicitly sets the value.
4443
#
@@ -114,43 +113,35 @@ class JavaAtomicFixnum
114113
MAX_VALUE = Java::JavaLang::Long::MAX_VALUE
115114

116115
# @!macro atomic_fixnum_method_initialize
117-
#
118116
def initialize(init = 0)
119117
raise ArgumentError.new('initial value must be a Fixnum') unless init.is_a?(Fixnum)
120118
@atomic = java.util.concurrent.atomic.AtomicLong.new(init)
121119
end
122120

123-
# @!macro atomic_fixnum_method_value
124-
#
121+
# @!macro atomic_fixnum_method_value_get
125122
def value
126123
@atomic.get
127124
end
128125

129-
# @!macro atomic_fixnum_method_value_eq
130-
#
126+
# @!macro atomic_fixnum_method_value_set
131127
def value=(value)
132128
raise ArgumentError.new('value must be a Fixnum') unless value.is_a?(Fixnum)
133129
@atomic.set(value)
134130
end
135131

136132
# @!macro atomic_fixnum_method_increment
137-
#
138133
def increment
139134
@atomic.increment_and_get
140135
end
141-
142136
alias_method :up, :increment
143137

144138
# @!macro atomic_fixnum_method_decrement
145-
#
146139
def decrement
147140
@atomic.decrement_and_get
148141
end
149-
150142
alias_method :down, :decrement
151143

152144
# @!macro atomic_fixnum_method_compare_and_set
153-
#
154145
def compare_and_set(expect, update)
155146
@atomic.compare_and_set(expect, update)
156147
end
@@ -160,6 +151,30 @@ def compare_and_set(expect, update)
160151
class AtomicFixnum < JavaAtomicFixnum
161152
end
162153

154+
elsif defined? Concurrent::CAtomicFixnum
155+
156+
# @!macro atomic_fixnum
157+
class CAtomicFixnum
158+
159+
# @!method initialize
160+
# @!macro atomic_fixnum_method_initialize
161+
162+
# @!method value
163+
# @!macro atomic_fixnum_method_value_get
164+
165+
# @!method value=
166+
# @!macro atomic_fixnum_method_value_set
167+
168+
# @!method increment
169+
# @!macro atomic_fixnum_method_increment
170+
171+
# @!method decrement
172+
# @!macro atomic_fixnum_method_decrement
173+
174+
# @!method compare_and_set
175+
# @!macro atomic_fixnum_method_compare_and_set
176+
end
177+
163178
else
164179

165180
# @!macro atomic_fixnum

0 commit comments

Comments
 (0)