fix(bytes32): use memcpy for std::hash to fix macOS build#190
Merged
hoytech merged 1 commit intohoytech:masterfrom Apr 15, 2026
Merged
Conversation
Owner
|
Makes sense, to ensure there's no unaligned access on CPUs where that matters. Probably the compiler can avoid the memcpy when not necessary. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #188.
It changes the following:
std::hash<Bytes32>insrc/Bytes32.h: remove the ill-formed cast fromsize_t*touint64_t*(fails on Apple Clang / arm64 wheresize_tanduint64_tare distinct typedefs).uint64_t words[4]withmemcpy, then XOR the four lanes—same hash shape as before, without pointer type punning.<cstdint>souint64_tis explicit in the header.Testing
make setup-golpe && make -j4(with dependencies available per README / your environment, e.g. HomebrewCPATH/LIBRARY_PATHon macOS)make src/Decompressor.o(quick check thatBytes32.hcompiles on the inclusion path used by the build)