Add checks to packed event parser to avoid index out of range errors / undefined behavior#205
Merged
hoytech merged 1 commit intohoytech:masterfrom Apr 22, 2026
Conversation
hoytech
approved these changes
Apr 22, 2026
Owner
hoytech
left a comment
There was a problem hiding this comment.
Packed events are always supposed to be trusted data, so in theory there's no need for these checks. However, since the impact is so minimal, maybe you're right to have these checks in as defensive code. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prior to this there were no checks of length before accessing indices. this could be a reason for ub.