Skip to content

Add checks to packed event parser to avoid index out of range errors / undefined behavior#205

Merged
hoytech merged 1 commit intohoytech:masterfrom
theAnuragMishra:fix-packed-event-parser
Apr 22, 2026
Merged

Add checks to packed event parser to avoid index out of range errors / undefined behavior#205
hoytech merged 1 commit intohoytech:masterfrom
theAnuragMishra:fix-packed-event-parser

Conversation

@theAnuragMishra
Copy link
Copy Markdown
Contributor

prior to this there were no checks of length before accessing indices. this could be a reason for ub.

Copy link
Copy Markdown
Owner

@hoytech hoytech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packed events are always supposed to be trusted data, so in theory there's no need for these checks. However, since the impact is so minimal, maybe you're right to have these checks in as defensive code. Thanks!

@hoytech hoytech merged commit a138b64 into hoytech:master Apr 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants