refactor: make NostrFilterGroup accept filters directly, add fromReq for REQ arrays#207
Merged
hoytech merged 1 commit intohoytech:masterfrom Apr 22, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The FIXME at line 266 notes that
NostrFilterGroup::unwrapped()should be the default constructor. Currently, the main constructor expects a full REQ message array (["REQ", "subId", {filter}, ...]) and callers that just have filter objects must go through theunwrapped()static factory — which internally builds a fake REQ array wrapper to call the same constructor.This refactoring:
fromReq()static method — used only byRelayIngesterwhen parsing actual client REQ messages.unwrapped()static method.Issue
src/filters.hfile on line number 266Testing