Add index bounds checks to negentropy ingester#219
Merged
hoytech merged 1 commit intohoytech:masterfrom Apr 28, 2026
Merged
Conversation
Owner
|
The size of the array is verified to be at least 2 in the So I don't think there actually is a missing bounds check anywhere. However, your PR does clean up the code, and will provide a better error message in case of a malformed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current state, it just trusts the input
arr.This pr adds a check to verify the length of the input before tryiing to access
arr.at(0)to check the type of the command.Additionally, there might be some performance benefits of doing
arr.get_array()beforehand and then direct index access instead of doingarr.at(i). Not sure how significant though.