feat: bump WsCloud to latest version#4374
Merged
GordonSmith merged 1 commit intohpcc-systems:candidate-3.x.xfrom May 7, 2025
Merged
feat: bump WsCloud to latest version#4374GordonSmith merged 1 commit intohpcc-systems:candidate-3.x.xfrom
GordonSmith merged 1 commit intohpcc-systems:candidate-3.x.xfrom
Conversation
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the WsCloud service to version 1.02 by introducing updated service definitions and updating the import in the main service file.
- Added a new WsCloud service file with updated interfaces and a CloudServiceBase class for version 1.02.
- Updated the import in the main CloudService file and removed the custom getPODs response parsing.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/comms/src/services/wsdl/WsCloud/v1.02/WsCloud.ts | New WsCloud service definitions and service base class targeting version 1.02 |
| packages/comms/src/services/wsCloud.ts | Updated import reference to the new WsCloud version and removed custom getPODs method |
Comments suppressed due to low confidence (1)
packages/comms/src/services/wsCloud.ts:8
- The removal of the custom getPODs implementation changes the expected response processing. Please verify that the new WS Cloud service version meets consumer expectations or update documentation/tests accordingly.
getPODs(): Promise<object[]> {
Member
Author
|
FYI @asselitx |
jeclrsg
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: