Skip to content

feat: bump WsCloud to latest version#4374

Merged
GordonSmith merged 1 commit intohpcc-systems:candidate-3.x.xfrom
GordonSmith:BUMP_WSCLOUD
May 7, 2025
Merged

feat: bump WsCloud to latest version#4374
GordonSmith merged 1 commit intohpcc-systems:candidate-3.x.xfrom
GordonSmith:BUMP_WSCLOUD

Conversation

@GordonSmith
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith commented May 7, 2025

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith requested review from Copilot and jeclrsg May 7, 2025 11:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the WsCloud service to version 1.02 by introducing updated service definitions and updating the import in the main service file.

  • Added a new WsCloud service file with updated interfaces and a CloudServiceBase class for version 1.02.
  • Updated the import in the main CloudService file and removed the custom getPODs response parsing.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/comms/src/services/wsdl/WsCloud/v1.02/WsCloud.ts New WsCloud service definitions and service base class targeting version 1.02
packages/comms/src/services/wsCloud.ts Updated import reference to the new WsCloud version and removed custom getPODs method
Comments suppressed due to low confidence (1)

packages/comms/src/services/wsCloud.ts:8

  • The removal of the custom getPODs implementation changes the expected response processing. Please verify that the new WS Cloud service version meets consumer expectations or update documentation/tests accordingly.
getPODs(): Promise<object[]> {

@GordonSmith
Copy link
Copy Markdown
Member Author

FYI @asselitx

@GordonSmith GordonSmith merged commit 784f7bb into hpcc-systems:candidate-3.x.x May 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants