Skip to content

feat: Relocate getPODs parsing into comms#4377

Merged
GordonSmith merged 1 commit intohpcc-systems:candidate-2.x.xfrom
GordonSmith:GET_PODS_PARSING
May 9, 2025
Merged

feat: Relocate getPODs parsing into comms#4377
GordonSmith merged 1 commit intohpcc-systems:candidate-2.x.xfrom
GordonSmith:GET_PODS_PARSING

Conversation

@GordonSmith
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith commented May 8, 2025

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested review from Copilot and jeclrsg May 8, 2025 11:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR relocates the getPODs parsing logic into the comms module to more clearly separate concerns in handling different WsCloud responses.

  • Added "allowSyntheticDefaultImports" to tsconfig for improved module import handling.
  • Introduced helper functions (isGetPODsResponse_v1_02, mapPorts, mapPods) and updated the CloudService.getPODs method to handle multiple response types.
  • Added a new dependency (@kubernetes/client-node) to package.json.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/comms/tsconfig.json Added compiler option to support synthetic defaults.
packages/comms/src/services/wsCloud.ts Refactored getPODs parsing and added helper mapping functions.
packages/comms/package.json Added new dependency for Kubernetes client support.

Comment thread packages/comms/src/services/wsCloud.ts Outdated
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith merged commit 52057f2 into hpcc-systems:candidate-2.x.x May 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants