feat: Relocate getPODs parsing into comms#4377
Merged
GordonSmith merged 1 commit intohpcc-systems:candidate-2.x.xfrom May 9, 2025
Merged
feat: Relocate getPODs parsing into comms#4377GordonSmith merged 1 commit intohpcc-systems:candidate-2.x.xfrom
GordonSmith merged 1 commit intohpcc-systems:candidate-2.x.xfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR relocates the getPODs parsing logic into the comms module to more clearly separate concerns in handling different WsCloud responses.
- Added "allowSyntheticDefaultImports" to tsconfig for improved module import handling.
- Introduced helper functions (isGetPODsResponse_v1_02, mapPorts, mapPods) and updated the CloudService.getPODs method to handle multiple response types.
- Added a new dependency (@kubernetes/client-node) to package.json.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/comms/tsconfig.json | Added compiler option to support synthetic defaults. |
| packages/comms/src/services/wsCloud.ts | Refactored getPODs parsing and added helper mapping functions. |
| packages/comms/package.json | Added new dependency for Kubernetes client support. |
39 tasks
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
fe46334 to
955b5cd
Compare
jeclrsg
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: