fix: optimize WUDetails call#4422
Merged
GordonSmith merged 1 commit intohpcc-systems:candidate-3.x.xfrom Jul 23, 2025
Merged
Conversation
691ca43 to
07a687c
Compare
07a687c to
4a62d30
Compare
4a62d30 to
bd5547b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the WUDetails call by improving performance and code clarity in workunit processing. The changes focus on reducing unnecessary array operations, optimizing property handling, and improving memory efficiency.
Key changes:
- Replaces array filtering with Map-based lookups for activity resolution
- Pre-allocates arrays and uses direct indexing instead of push operations
- Optimizes object property extraction and variable reuse
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/comms/src/ecl/workunit.ts | Main optimization improvements including Map-based activity lookups, pre-allocated arrays, and streamlined property handling |
| packages/comms/src/ecl/query.ts | Minor performance improvements with Set-based property checking and batch property additions |
bd5547b to
831bbef
Compare
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
831bbef to
24a0d2d
Compare
jeclrsg
approved these changes
Jul 23, 2025
GordonSmith
added a commit
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
added a commit
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
added a commit
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
added a commit
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
added a commit
that referenced
this pull request
Jul 24, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
added a commit
that referenced
this pull request
Jul 24, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
added a commit
that referenced
this pull request
Jul 24, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
added a commit
that referenced
this pull request
Jul 24, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: