Skip to content

fix: optimize WUDetails call#4422

Merged
GordonSmith merged 1 commit intohpcc-systems:candidate-3.x.xfrom
GordonSmith:WUDETAILS_PERF
Jul 23, 2025
Merged

fix: optimize WUDetails call#4422
GordonSmith merged 1 commit intohpcc-systems:candidate-3.x.xfrom
GordonSmith:WUDETAILS_PERF

Conversation

@GordonSmith
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith commented Jul 23, 2025

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from Copilot July 23, 2025 07:02

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the WUDetails call by improving performance and code clarity in workunit processing. The changes focus on reducing unnecessary array operations, optimizing property handling, and improving memory efficiency.

Key changes:

  • Replaces array filtering with Map-based lookups for activity resolution
  • Pre-allocates arrays and uses direct indexing instead of push operations
  • Optimizes object property extraction and variable reuse

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/comms/src/ecl/workunit.ts Main optimization improvements including Map-based activity lookups, pre-allocated arrays, and streamlined property handling
packages/comms/src/ecl/query.ts Minor performance improvements with Set-based property checking and batch property additions

Comment thread packages/comms/src/ecl/workunit.ts Outdated
Comment thread packages/comms/src/ecl/workunit.ts Outdated
Comment thread packages/comms/src/ecl/query.ts
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith merged commit 6e38797 into hpcc-systems:candidate-3.x.x Jul 23, 2025
1 check failed
GordonSmith added a commit that referenced this pull request Jul 23, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith added a commit that referenced this pull request Jul 23, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith added a commit that referenced this pull request Jul 23, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith added a commit that referenced this pull request Jul 23, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith added a commit that referenced this pull request Jul 24, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith added a commit that referenced this pull request Jul 24, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith added a commit that referenced this pull request Jul 24, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith added a commit that referenced this pull request Jul 24, 2025
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants