Skip to content

feat(comms): allow WUResult to set BypassCachedResult in request#4437

Merged
GordonSmith merged 1 commit intohpcc-systems:candidate-3.x.xfrom
jeclrsg:wuResult-bypass-cache
Aug 25, 2025
Merged

feat(comms): allow WUResult to set BypassCachedResult in request#4437
GordonSmith merged 1 commit intohpcc-systems:candidate-3.x.xfrom
jeclrsg:wuResult-bypass-cache

Conversation

@jeclrsg
Copy link
Copy Markdown
Contributor

@jeclrsg jeclrsg commented Aug 19, 2025

changes the WUResult widget in the eclwatch package & ecl/result helper in comms to allow setting the BypassCachedResult param in requests to WorkunitsService.WUResult

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@jeclrsg jeclrsg requested a review from Copilot August 19, 2025 16:57
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to allow bypassing cached results in the WUResult widget and ECL result helper. It introduces a new bypassCache parameter that can be set to force fresh data retrieval instead of using cached results.

  • Adds bypassCache property to WUResult widget with getter/setter methods
  • Updates Result class to handle bypass cache functionality in data fetching
  • Passes bypassCache parameter through to WsWorkunits WUResult requests

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/eclwatch/src/WUResult.ts Adds bypassCache property and ensures it's passed to Result instances
packages/comms/src/ecl/result.ts Implements bypassCache functionality in Result class and WUResult API calls

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/comms/src/ecl/result.ts Outdated
Comment thread packages/comms/src/ecl/result.ts Outdated
changes the WUResult widget in the eclwatch package & ecl/result helper
in comms to allow setting the BypassCachedResult param in requests to
WorkunitsService.WUResult

Signed-off-by: Jeremy Clements <79224539+jeclrsg@users.noreply.github.com>
@GordonSmith GordonSmith merged commit 23c2d1c into hpcc-systems:candidate-3.x.x Aug 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants