feat(comms): allow WUResult to set BypassCachedResult in request#4437
Merged
GordonSmith merged 1 commit intohpcc-systems:candidate-3.x.xfrom Aug 25, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to allow bypassing cached results in the WUResult widget and ECL result helper. It introduces a new bypassCache parameter that can be set to force fresh data retrieval instead of using cached results.
- Adds
bypassCacheproperty to WUResult widget with getter/setter methods - Updates Result class to handle bypass cache functionality in data fetching
- Passes bypassCache parameter through to WsWorkunits WUResult requests
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/eclwatch/src/WUResult.ts | Adds bypassCache property and ensures it's passed to Result instances |
| packages/comms/src/ecl/result.ts | Implements bypassCache functionality in Result class and WUResult API calls |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
changes the WUResult widget in the eclwatch package & ecl/result helper in comms to allow setting the BypassCachedResult param in requests to WorkunitsService.WUResult Signed-off-by: Jeremy Clements <79224539+jeclrsg@users.noreply.github.com>
aa5b567 to
0405d6c
Compare
39 tasks
GordonSmith
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes the WUResult widget in the eclwatch package & ecl/result helper in comms to allow setting the BypassCachedResult param in requests to WorkunitsService.WUResult
Checklist:
Testing: