fix: improve runtime placeholder handling#4451
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves runtime placeholder handling in the observablehq-compiler package by refactoring the API to better manage cell lifecycle operations. The changes rename functions for consistency and enhance error handling for cell operations.
- Renamed
compileKittocompileNotebookfor better naming consistency - Enhanced runtime cell management with improved add/update/remove operations
- Added proper error handling for cell state management
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/observablehq-compiler/tests/index-notebookkit.ts | Updates import and function call to use new compileNotebook name |
| packages/observablehq-compiler/tests/index-notebookkit.js | Updates import and function call to use new compileNotebook name |
| packages/observablehq-compiler/src/kit/runtime.ts | Major refactor of cell management methods with better error handling |
| packages/observablehq-compiler/src/kit/index.ts | Reorders exports |
| packages/observablehq-compiler/src/kit/compiler.ts | Refactors compilation logic and renames functions |
| packages/observablehq-compiler/src/index.ts | Updates exports to use new function names |
| packages/observablehq-compiler/src/compiler.ts | Updates function call to use new compileNotebook name |
| packages/observablehq-compiler/index-kit.html | Uncomments CSS styles |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c262bc5 to
651cf79
Compare
651cf79 to
23e9e75
Compare
23e9e75 to
784a1cd
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jeclrsg
left a comment
There was a problem hiding this comment.
@GordonSmith I didn't have anything to add; couple of pending copilot comments however
Fixes previous issues with update and remove Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
784a1cd to
95074fc
Compare
Fixes previous issues with update and remove
Checklist:
Testing: