Skip to content

Fix release step build-executables on Windows #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkfellows merged 1 commit into from
Jan 6, 2026
Merged

Fix release step build-executables on Windows #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/release-impl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,15 @@ jobs:
- name: Install dependencies
run: poetry install --without dev

- name: Install cached app data
env:
PYTHONUTF8: 1
run: |
poetry run ${{ inputs.executable_name }} data install-cache ${{ inputs.executable_name }}-app-data-cache/data
poetry run ${{ inputs.executable_name }} data --list
poetry run ${{ inputs.executable_name }} program install-cache ${{ inputs.executable_name }}-app-data-cache/programs
poetry run ${{ inputs.executable_name }} program --list

- name: Build with pyinstaller (non-Windows, file)
if: runner.os != 'Windows'
working-directory: ${{ inputs.pyinstaller_dir }}
Expand Down Expand Up @@ -420,15 +429,6 @@ jobs:
expected: "${{ inputs.app_name }}, version ${{ needs.bump-version.outputs.version }}"
command: ${{ env.BUILT_EXE_PATH_DIR }} --version

- name: Install cached app data
env:
PYTHONUTF8: 1
run: |
${{ env.BUILT_EXE_PATH_DIR }} data install-cache ${{ inputs.executable_name }}-app-data-cache/data
${{ env.BUILT_EXE_PATH_DIR }} data --list
${{ env.BUILT_EXE_PATH_DIR }} program install-cache ${{ inputs.executable_name }}-app-data-cache/programs
${{ env.BUILT_EXE_PATH_DIR }} program --list

- name: Run test suite on the frozen app (folder)
env:
GH_TOKEN: ${{ secrets.general-token }}
Expand Down