Skip to content

Don't put the app data cache in the benchmark data #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkfellows merged 1 commit into from
Apr 20, 2026
Merged

Don't put the app data cache in the benchmark data #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions .github/workflows/release-impl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v6
with:
ref: ${{ inputs.ref }}
ref: ${{ inputs.pr-head-ref }}

- name: Set up python
uses: actions/setup-python@v6
Expand Down Expand Up @@ -331,6 +331,7 @@ jobs:
with:
name: ${{ inputs.executable_name }}-app-data-cache
path: ~/.cache/${{ inputs.executable_name }}
retention-days: 1

build-executables:
needs: [bump-version, cache-app-data]
Expand Down Expand Up @@ -464,6 +465,7 @@ jobs:
runs-on: ubuntu-latest
needs: [bump-version, cache-app-data]
env:
BUILT_EXE_BASE_NAME: ${{ inputs.executable_name }}-${{ needs.bump-version.outputs.new_tag }}
BUILT_EXE_PATH_DIR: ${{ inputs.pyinstaller_dir }}/dist/onedir/${{ inputs.executable_name }}-${{ needs.bump-version.outputs.new_tag }}-linux-dir/${{ inputs.executable_name }}-${{ needs.bump-version.outputs.new_tag }}-linux-dir
BUILT_EXE_PATH_DIR_ZIPPED: ${{ inputs.pyinstaller_dir }}/dist/onedir/${{ inputs.executable_name }}-${{ needs.bump-version.outputs.new_tag }}-linux-dir.zip
BUILT_EXE_PATH_FILE: ${{ inputs.pyinstaller_dir }}/dist/onefile/${{ inputs.executable_name }}-${{ needs.bump-version.outputs.new_tag }}-linux
Expand Down Expand Up @@ -597,8 +599,23 @@ jobs:
path: benchmark_make_workflow_${{ matrix.num_elements }}_elements-${{ runner.os }}-py-${{ matrix.python-version }}.txt
retention-days: 1

cleanup-cache:
needs:
- build-executables
- build-executables-linux
runs-on: ubuntu-latest
steps:
- name: Delete cache artifact
uses: geekyeggo/delete-artifact@v6
with:
name: "*-app-data-cache"
failOnError: false


make-workflow-benchmark-upload:
needs: make-workflow-benchmark
needs:
- make-workflow-benchmark
- cleanup-cache
runs-on: ubuntu-latest
outputs:
benchmark-url: ${{ steps.upload.outputs.artifact-url }}
Expand Down