Skip to content

Increase ref performance #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NickNeck merged 5 commits into from
Jan 24, 2019
Merged

Increase ref performance #76

NickNeck merged 5 commits into from
Jan 24, 2019

Conversation

@NickNeck
Copy link
Member

@NickNeck NickNeck commented Jan 20, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jan 20, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6eb99cc on performance/ref into 24f717b on master.

@NickNeck
Copy link
Member Author

NickNeck commented Jan 20, 2019 •
edited
Loading 

Benchmarking ref...

Name                   ips        average  deviation         median         99th %
ref               395.91 K        2.53 μs  ±1136.12%           2 μs           5 μs
ref (master)       66.47 K       15.04 μs    ±99.45%          13 μs          43 μs

Comparison:
ref               395.91 K
ref (master)       66.47 K - 5.96x slower

TODOs

  • Fix remote ref
  • Don't put exisitng refs
  • Rename :root to :trace
  • Add test for invalid refs
  • Clean up, credo, dialyzer

@NickNeck NickNeck merged commit 86a08c2 into master Jan 24, 2019
@NickNeck NickNeck deleted the performance/ref branch January 24, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NickNeck @coveralls