Skip to content

ci: PR 제목 Conventional 검증 추가 및 이슈/팀 설정 정비#95

Merged
6-keem merged 4 commits into
mainfrom
ci/pr-title-check
Jun 13, 2026
Merged

ci: PR 제목 Conventional 검증 추가 및 이슈/팀 설정 정비#95
6-keem merged 4 commits into
mainfrom
ci/pr-title-check

Conversation

@6-keem

@6-keem 6-keem commented Jun 13, 2026

Copy link
Copy Markdown
Member

Closes #94

변경 내용

  • pr-title.yml: 스쿼시 머지 시 PR 제목이 release-please 버전 산출에 쓰이므로, PR 제목이 Conventional Commits인지 CI에서 검사 (머지 후 필수 체크로 등록 예정)
  • .github/ISSUE_TEMPLATE/task.yml: 버그/기능이 아닌 작업(문서·CI·리팩터 등)용 이슈 템플릿 추가
  • /create-issue 스킬: gh issue create가 YAML 템플릿을 적용하지 않으므로, 스킬이 템플릿 파일을 읽어 동일 구조로 본문을 렌더링하도록 변경
  • .claude/: dotbugi에 맞게 정리한 팀 지침·rules·skills 저장소 추적 (개인 설정/로컬 인덱스는 .gitignore)

변경 유형

  • ⚙️ 빌드/CI

체크리스트

머지 후 (메인테이너)

  • PR 제목 검증 체크를 main 브랜치 보호 필수 체크에 추가

Summary by CodeRabbit

  • Documentation

    • 팀 작업 방식·역할 분리, 릴리즈·브랜치·커밋 규칙 등 작업 프로세스 정리
    • 코드 컨벤션(주석 언어·포맷·타입 규칙), TypeScript/React 규칙 및 i18n 지침 추가
    • LLM 안전·오류 방지 행동 지침과 여러 스킬(이슈 분석·PR 생성·리뷰 반영·구현·재현 테스트·품질검토 등) 문서화
  • Chores

    • 이슈 템플릿 및 PR 제목 검증 워크플로우 추가
    • 로컬 인덱스/캐시·개인 설정 파일을 .gitignore에 추가

6-keem added 3 commits June 14, 2026 02:38
- pr-title.yml: 스쿼시 머지 시 PR 제목이 release-please 버전 산출에 쓰이므로
  PR 제목이 Conventional Commits인지 CI에서 검사 (필수 체크로 등록 예정)
- dotbugi에 맞게 정리한 .claude(팀 지침/rules/skills) 저장소 추적
- .gitignore: .hedwig-cg 인덱스, .claude/settings.local.json 제외

Closes #94
- task.yml: 기능/버그가 아닌 작업(문서·CI·리팩터 등)용 이슈 템플릿
- create-issue 스킬: gh issue create가 YAML 템플릿을 적용하지 않으므로,
  스킬이 .github/ISSUE_TEMPLATE/*.yml을 읽어 그 구조대로 본문을 렌더링하도록 변경
  (CLI 생성 이슈 = 웹 폼 이슈 동일 형태)
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7683c7b3-901e-46e8-98f3-a999398112fd

📥 Commits

Reviewing files that changed from the base of the PR and between b23f21a and 48df05f.

📒 Files selected for processing (6)
  • .claude/CLAUDE.md
  • .claude/rules/common.md
  • .claude/skills/apply-pr-reviews/SKILL.md
  • .claude/skills/create-pr/SKILL.md
  • .claude/skills/hedwig-cg/SKILL.md
  • .claude/skills/issues/SKILL.md
✅ Files skipped from review due to trivial changes (6)
  • .claude/CLAUDE.md
  • .claude/skills/issues/SKILL.md
  • .claude/rules/common.md
  • .claude/skills/create-pr/SKILL.md
  • .claude/skills/apply-pr-reviews/SKILL.md
  • .claude/skills/hedwig-cg/SKILL.md

📝 Walkthrough

Walkthrough

PR #95는 .claude/ 내부 팀 가이드·규칙·AI 스킬 문서를 저장소에 추가하고, PR 제목 검증 워크플로우와 작업 이슈 템플릿을 추가했으며 일부 로컬 설정/캐시를 .gitignore에 등록합니다.

Changes

팀 협업 지침 및 자동화 구성

Layer / File(s) Summary
팀 가이드라인 및 코딩 규칙
.claude/CLAUDE.md, .claude/rules/common.md, .claude/rules/typescript.md
팀 작업 방식, 공통 규칙(주석 한국어, Conventional Commits, Prettier 등), TypeScript/React 규칙(타입 명시, 함수형 컴포넌트, DOMParser 스크래핑, Shadow DOM 격리, i18n 등)을 문서로 정의합니다.
AI 협업 스킬 워크플로우
.claude/skills/*.md
이슈 분석, 이슈 생성, PR 생성, PR 리뷰 반영, hedwig-cg 검색, 구현·리팩터·품질검토·재현 테스트 등 AI 보조 작업의 단계별 실행 절차를 문서화합니다.
GitHub 자동화 및 이슈 템플릿
.github/ISSUE_TEMPLATE/task.yml, .github/workflows/pr-title.yml
작업 이슈 템플릿과 PR 제목을 Conventional Commits 형식으로 검증하는 GitHub Actions 워크플로우를 추가합니다.
저장소 설정 및 구성
.claude/settings.json, .gitignore
.claude 설정 파일을 추적하고 로컬 인덱스(.hedwig-cg/)와 개인 설정(.claude/settings.local.json)을 무시하도록 .gitignore를 확장합니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

📝 docs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목이 CI 워크플로 추가와 팀 설정 정비라는 주요 변경사항을 명확하게 요약하고 있으며, Conventional Commits 형식을 따르고 있다.
Linked Issues check ✅ Passed PR이 #94의 모든 주요 요구사항(PR 제목 검증 CI 워크플로, .claude 팀 설정 추적)을 구현했으며, 이슈 템플릿 추가 및 create-issue 스킬도 함께 포함하고 있다.
Out of Scope Changes check ✅ Passed 모든 변경사항이 #94의 범위 내에 있으며, PR 제목 검증, .claude 디렉터리 정리, 이슈 템플릿 추가, .gitignore 확장이 모두 이슈의 목표 달성에 필요한 변경사항이다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/pr-title-check

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the ci CI/CD 설정 변경 label Jun 13, 2026
@6-keem 6-keem added the chore 빌드/도구/설정 등 잡일 label Jun 13, 2026
@github-actions github-actions Bot removed the chore 빌드/도구/설정 등 잡일 label Jun 13, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
.claude/skills/analyze-issue/SKILL.md (1)

13-15: ⚡ Quick win

셸 예제 코드 블록에 언어를 지정해 주세요.

markdownlint가 이 파일들의 코드 블록을 경고로 잡고 있습니다. bash 또는 shell을 붙이면 lint 경고를 없애고 예제도 더 쉽게 복사할 수 있습니다.

  • analyze-issue: gh issue view / gh issue comment 블록에 언어 태그 추가
  • apply-pr-reviews: gh pr view / gh api 블록에 언어 태그 추가
  • create-issue: gh issue create 블록에 언어 태그 추가
  • create-pr: git / gh pr create 블록에 언어 태그 추가
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.claude/skills/analyze-issue/SKILL.md around lines 13 - 15, Add a shell
language tag to the fenced code blocks containing CLI examples so markdownlint
stops warning; specifically, change the opening fences to "```bash" (or
"```shell") for each affected site: in .claude/skills/analyze-issue/SKILL.md
lines 13-15 (the "gh issue view <번호> ..." block) and lines 39-41 (the "gh issue
comment" block), in .claude/skills/apply-pr-reviews/SKILL.md lines 13-15 and
21-25 (the "gh pr view" / "gh api" blocks), in
.claude/skills/create-issue/SKILL.md lines 32-37 (the "gh issue create" block),
and in .claude/skills/create-pr/SKILL.md lines 33-35 and 45-51 (the "git" / "gh
pr create" blocks); no other code changes required.

Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.claude/CLAUDE.md:
- Around line 23-27: Update the PR-title Conventional Commit types to match the
validator (include build, perf, style, revert alongside feat, fix, refactor,
chore, docs, test, ci) across the three files: in .claude/CLAUDE.md (lines
23-27) replace the current narrower list and examples so the allowed types
exactly mirror the validator and make the example PR title follow Conventional
Commits (use English if you decide to require English-only); in
.claude/rules/common.md (lines 13-14) update the allowed types list to the same
full set as the validator; and in .claude/skills/create-pr/SKILL.md (lines
19-27) change the allowed types to the validator’s full set and make the example
consistent with the chosen language policy (if requiring English, convert the
example to an English Conventional Commit title).

In @.claude/skills/apply-pr-reviews/SKILL.md:
- Around line 44-47: Update the CI verification step in "5단계: 검증·커밋" to include
Prettier format check so it matches the actual pr-checks; specifically add the
Prettier command (npx prettier --check .) to the list alongside `npm run lint` /
`npm run build` / `npm run test` so contributors run the same formatting check
locally before committing.

In @.claude/skills/hedwig-cg/SKILL.md:
- Around line 26-30: The markdown fenced code blocks at the listed sites lack
language tags and trigger MD040; add explicit language tags: for
.claude/skills/hedwig-cg/SKILL.md lines 26-30 and 44-53 mark those
example/description blocks as ```text (or convert them to normal markdown
paragraphs/lists), for .claude/skills/implement/SKILL.md lines 11-13, 21-24 and
38-42 mark the command examples as ```bash, for .claude/skills/issues/SKILL.md
lines 9-12 mark the command example as ```bash, for
.claude/skills/quality-review/SKILL.md lines 11-14 and 28-31 mark the command
examples as ```bash, for .claude/skills/refactor/SKILL.md lines 10-13 and 28-31
mark the command examples as ```bash, and for .claude/skills/repro-test/SKILL.md
lines 29-31 mark the command example as ```bash; no other code changes required.

In @.claude/skills/issues/SKILL.md:
- Line 14: The wording incorrectly calls the gh project item-list <번호> an "이슈
번호"; update the sentence to say that the parameter is a 프로젝트 번호 (or project URL)
not an issue number, e.g. clarify "gh project item-list <번호|프로젝트 URL> — 여기서
<번호>는 프로젝트 번호입니다" and adjust the example to show "프로젝트 '1'의 항목 나열" and note that
if the board is missing or read:project scope is absent it will skip and print
only issues; change the fragment referencing "이슈 번호" to "프로젝트 번호/URL" and keep
the rest of the behavior description unchanged.

---

Nitpick comments:
In @.claude/skills/analyze-issue/SKILL.md:
- Around line 13-15: Add a shell language tag to the fenced code blocks
containing CLI examples so markdownlint stops warning; specifically, change the
opening fences to "```bash" (or "```shell") for each affected site: in
.claude/skills/analyze-issue/SKILL.md lines 13-15 (the "gh issue view <번호> ..."
block) and lines 39-41 (the "gh issue comment" block), in
.claude/skills/apply-pr-reviews/SKILL.md lines 13-15 and 21-25 (the "gh pr view"
/ "gh api" blocks), in .claude/skills/create-issue/SKILL.md lines 32-37 (the "gh
issue create" block), and in .claude/skills/create-pr/SKILL.md lines 33-35 and
45-51 (the "git" / "gh pr create" blocks); no other code changes required.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 63e2bcf6-32b1-4341-93a5-6e60edd74662

📥 Commits

Reviewing files that changed from the base of the PR and between ee5f445 and b23f21a.

📒 Files selected for processing (18)
  • .claude/CLAUDE.md
  • .claude/rules/common.md
  • .claude/rules/typescript.md
  • .claude/settings.json
  • .claude/skills/analyze-issue/SKILL.md
  • .claude/skills/apply-pr-reviews/SKILL.md
  • .claude/skills/compound/SKILL.md
  • .claude/skills/create-issue/SKILL.md
  • .claude/skills/create-pr/SKILL.md
  • .claude/skills/hedwig-cg/SKILL.md
  • .claude/skills/implement/SKILL.md
  • .claude/skills/issues/SKILL.md
  • .claude/skills/quality-review/SKILL.md
  • .claude/skills/refactor/SKILL.md
  • .claude/skills/repro-test/SKILL.md
  • .github/ISSUE_TEMPLATE/task.yml
  • .github/workflows/pr-title.yml
  • .gitignore

Comment thread .claude/CLAUDE.md
Comment thread .claude/skills/apply-pr-reviews/SKILL.md
Comment thread .claude/skills/hedwig-cg/SKILL.md Outdated
Comment thread .claude/skills/issues/SKILL.md Outdated
- PR 제목 허용 타입을 pr-title.yml 기준으로 문서 통일(CLAUDE.md/common.md/create-pr)
- apply-pr-reviews 검증 목록에 prettier --check 추가
- hedwig-cg 코드펜스에 text 언어 태그(MD040)
- issues: gh project item-list <번호>는 프로젝트 번호임을 명확화
@6-keem

6-keem commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@6-keem 6-keem merged commit 90e798e into main Jun 13, 2026
8 checks passed
@6-keem 6-keem deleted the ci/pr-title-check branch June 13, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD 설정 변경

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore] PR 제목 Conventional 검증 CI 추가 및 .claude 팀 설정 추적

1 participant