Use node: protocol for imports where possible#112
Merged
DmitrySharabin merged 2 commits intohtest-dev:mainfrom Dec 29, 2025
Merged
Use node: protocol for imports where possible#112DmitrySharabin merged 2 commits intohtest-dev:mainfrom
node: protocol for imports where possible#112DmitrySharabin merged 2 commits intohtest-dev:mainfrom
Conversation
This makes it really easy to see which imports are from the NodeJS standard lib. It also disambiguates 3rd-party packages that might have similar looking names.
✅ Deploy Preview for h-test ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LeaVerou
approved these changes
Dec 29, 2025
Member
LeaVerou
left a comment
LeaVerou
left a comment
There was a problem hiding this comment.
Oh that's a good point, I never considered this. Thanks!
DmitrySharabin
requested changes
Dec 29, 2025
Member
DmitrySharabin
left a comment
DmitrySharabin
left a comment
There was a problem hiding this comment.
I deeply support these changes (this is what I try to do in all our new projects). Do you mind adding tests/index.js to this PR? I haven’t spotted any other files that also need to be changed.
Contributor
Author
|
Will do! |
Contributor
Author
|
@DmitrySharabin Oh…I…already did |
DmitrySharabin
approved these changes
Dec 29, 2025
Member
DmitrySharabin
left a comment
DmitrySharabin
left a comment
There was a problem hiding this comment.
Oh, right. My bad!
LGTM, then!
Thanks. 🤝
Contributor
Author
|
Got Merge™? |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👍 Makes it really easy to see which imports are from the NodeJS standard lib!