First stab at adding support for setup() and teardown()

[DmitrySharabin]

I still need to add some docs, but I want to ensure I get the idea right.

My local experiments with another project show that those inheritable methods work.

@LeaVerou, I'd love to hear your thoughts on this.

[netlify]

✅ Deploy Preview for h-test ready!

Name	Link
🔨 Latest commit	098c644
🔍 Latest deploy log	https://app.netlify.com/sites/h-test/deploys/67917e72ae3b830008f3516c
😎 Deploy Preview	https://deploy-preview-65--h-test.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[LeaVerou]

LGTM. Though it might be a simpler design to just define no-op setup() and teardown() methods (so there's always something there) and then just assign any user-provided ones to this.setup/this.teardown. I think it would lead to strictly less code, since we now have two methods that do nothing more than call two other methods :P Even the context is the same.

[DmitrySharabin]

LGTM. Though it might be a simpler design to just define no-op setup() and teardown() methods (so there's always something there) and then just assign any user-provided ones to this.setup/this.teardown. I think it would lead to strictly less code, since we now have two methods that do nothing more than call two other methods :P Even the context is the same.

That's an excellent idea!

I have a question, though. I used this.setup/this.teardown to promisify setup() and teardown() so we can chain them with this.run. Should I do the same in the design you proposed? Do we need a utility to promisify a function? Or am I doing something wrong here?

UPDATE

I think I know the answer: we can simply do Promise.resolve(this.test.setup()). I'll commit the change after testing it.

[DmitrySharabin]

Thank you for your suggestions on how to improve the design. 🙏 Now, the code is much-much simpler.
Could you please take another look to make sure I got everything correctly?