Don't intercept console when not in Node#70
Merged
DmitrySharabin merged 1 commit intomainfrom Jan 29, 2025
Merged
Conversation
Otherwise, when running JS-first tests in the browser, we lose all the console messages produced by the tests.
✅ Deploy Preview for h-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LeaVerou
approved these changes
Jan 29, 2025
Member
LeaVerou
left a comment
LeaVerou
left a comment
There was a problem hiding this comment.
This is fine for now. We might eventually want to intercept non-Node so perhaps this should be up to the test runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, when running JS-first tests in the browser, we lose all the console messages produced by the tests.