Fix bug with error-based tests, closes #76#82
Merged
DmitrySharabin merged 1 commit intomainfrom Feb 13, 2025
Merged
Conversation
- Classes are functions, so we need to check for a subclass first
- Check if a class's prototype is an instance of Error, not class itself
- Use class name in details to avoid something like `function TypeError () { [native code] }`
✅ Deploy Preview for h-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DmitrySharabin
force-pushed
the
error-based-tests-bug
branch
from
82813db to
5d8224b
Compare
LeaVerou
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
function TypeError () { [native code] }