Respect the verbose option when printing out results#97
Merged
DmitrySharabin merged 4 commits intomainfrom Jun 18, 2025
Merged
Conversation
✅ Deploy Preview for h-test ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Unfortunately, we don’t have many ANSI colors to choose from, so I decided to stick with yellow.
DmitrySharabin
force-pushed
the
fix-verbose
branch
from
b4616bc to
52dac2f
Compare
DmitrySharabin
force-pushed
the
fix-verbose
branch
from
52dac2f to
6a6ab0f
Compare
LeaVerou
approved these changes
Jun 18, 2025
This was referenced Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, even if we specify that option, groups with all passed tests won’t be shown. In CI/CD, this option is not respected even partially. Rel to #7 and #96.
With the changes, one can enable verbose output via the
--verboseCLI argument.I also changed the formatting of skipped tests. For now, they are formatted as failed. Unfortunately, we don’t have many ANSI colors to choose from, so I decided to stick with yellow (I also tried black, as it was the closest to gray, but I thought the final look wasn't decent enough).
As a result of all these changes, we can get (when testing
color.js):Running tests with both options (
ciandverbose) enabled allows us to (at least partially) address use cases mentioned by @kleinfreund in #96.