feat: default browserless onboarding and request strategies#895
Merged
gildesmarais merged 9 commits intomainfrom Mar 21, 2026
Merged
feat: default browserless onboarding and request strategies#895gildesmarais merged 9 commits intomainfrom
gildesmarais merged 9 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the html2rss-web onboarding and metadata surfaces so new users default to the browserless/JavaScript strategy, while also promoting built-in/embedded feed configs via the API and UI.
Changes:
- Defaults onboarding strategy selection to
browserlessin the frontend (with auto-submit support for?url=flows) and aligns tests/mocks. - Exposes
featured_feedson the API v1 root metadata and adds backend support for resolving embedded config paths viaLocalConfig. - Updates backend defaults to defer to
Html2rss::RequestService.default_strategy_nameinstead of hard-coding:faraday.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/html2rss/web/local_config_spec.rb | Adds coverage for embedded-config fallback and malformed path handling. |
| spec/html2rss/web/feeds/source_resolver_spec.rb | Aligns static generator strategy defaulting with request-service default. |
| spec/html2rss/web/api/v1_spec.rb | Verifies API root returns featured_feeds. |
| app/web/config/local_config.rb | Adds embedded-config lookup and path-style normalization for feed names. |
| app/web/api/v1/root_metadata.rb | Adds featured_feeds to root metadata response. |
| app/web/feeds/source_resolver.rb | Uses request-service default strategy when static config omits strategy. |
| app/web/domain/auto_source.rb | Uses request-service default strategy for stable feed creation. |
| frontend/src/components/App.tsx | Prefers browserless by default, supports auto-submit, passes featured feeds + OpenAPI URL to UI. |
| frontend/src/components/AppPanels.tsx | Tweaks labels/styling, adds featured-feeds promotion panel, reorders utility links. |
| frontend/src/api/contracts.ts | Extends metadata contract with optional featured_feeds. |
| frontend/src/tests/* | Updates mocks and adds tests for new defaults, featured feeds, and utility link ordering. |
| docker-compose.yml | Switches to optional .env env_file and documents how to override bundled feeds.yml. |
|
@gildesmarais you don't need |
Member
Author
|
Moin @mrlubos Thank you! Thank you very much for hey-api project and the personal support. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification