Make GPU residue values consistent across meter instances #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenBE
added
enhancement
Explorer09
force-pushed
the
gpu-meter-residue-percentage
branch
2 times, most recently
from
88ae698 to
a341f4e
Compare
Explorer09
force-pushed
the
gpu-meter-residue-percentage
branch
2 times, most recently
from
e519528 to
dc932f8
Compare
Explorer09
force-pushed
the
gpu-meter-residue-percentage
branch
from
dc932f8 to
533a30f
Compare
Signed-off-by: Kang-Che Sung <explorer09@gmail.com>
GPUMeter_updateValues() used a locally cached "residue time" variable for computing the percentage of the "GPU residue" usage. The "residue" percentages of subsequent GPUMeter instances could be 0 due to the cached "residue time" off-sync with the time data from the LinuxMachine instance. Rewrite the logic of the function so that all computed GPU percentage values are cached, and the cache updated only when there's increment on host->monotonicMs. Signed-off-by: Kang-Che Sung <explorer09@gmail.com>
Explorer09
force-pushed
the
gpu-meter-residue-percentage
branch
from
533a30f to
52f2d3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPUMeter_updateValues()used a locally cached "residue time" variable for computing the percentage of the "GPU residue" usage. The "residue" percentages of subsequentGPUMeterinstances could be 0 due to the cached "residue time" off-sync with the time data from theLinuxMachineinstance.Rewrite the logic of the function so that all computed GPU percentage values are cached, and the cache updated only when there's increment on
host->monotonicMs.