Properly handle potential NULL-deref issues

[BenBE]

While the value of optarg semantically is non-zero for required arguments, this isn't obvious for static code analyzers. Thus this PR first adds the missing asserts to make this consistent, before then upgrading those to full-on argument parsing failures.

Ref: Coverity issue CID 645928.

Summary by CodeRabbit

• Bug Fixes
  • Improved validation of command-line arguments for the sort-key, delay, max-iterations, and filter options. The app now checks that required values are provided and returns a clear error when arguments are missing, preventing crashes or undefined behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 52c5812a-e378-4177-9b4a-cf37bdb3d8d6

📥 Commits

Reviewing files that changed from the base of the PR and between d81043e and 18fcb1a.

📒 Files selected for processing (1)

• CommandLine.c

---

📝 Walkthrough

Walkthrough

This PR updates CommandLine.c to validate that optarg is non-NULL for four options: -s/--sort-key, -d/--delay, -n/--max-iterations, and -F/--filter. Each affected case now returns STATUS_ERROR_EXIT immediately when optarg is missing; two previously used assert(optarg) are replaced with runtime checks.

Poem

🐰 I hop through args with careful cheer,

I sniff for NULL where once was fear,
Four flags now guard their trailing bit,
If none is found, I bail—quickly quit,
A tidy exit, carrot-approved, hop-sweet!

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}